Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename proto: enable_memory_snapshot -> enable_snapshot #2779

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

thecodingwizard
Copy link
Contributor

follow-up to #2774. this isn't used by anyone yet.

@thecodingwizard
Copy link
Contributor Author

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@thecodingwizard
Copy link
Contributor Author

@prbot automerge

@modal-pr-review-automation
Copy link

Some required workflows are pending. Will automerge once they complete successfully.

@modal-pr-review-automation modal-pr-review-automation bot merged commit 7adbcc1 into main Jan 17, 2025
23 checks passed
@modal-pr-review-automation modal-pr-review-automation bot deleted the nathan/sandbox-proto-2 branch January 17, 2025 22:19
@mwaskom
Copy link
Contributor

mwaskom commented Jan 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants